Ignore exit codes from "npm list --json" as they can be misleading #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead just try and parse the JSON on stdout. If the command doesn't produce JSON fail, then the error handler still exists. Bugs in npm or packaging like https://bugzilla.redhat.com/show_bug.cgi?id=986422 can cause package lists to come back empty even if the error's harmless.
apenney
pushed a commit
that referenced
this pull request
Nov 20, 2013
Ignore exit codes from "npm list --json" as they can be misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead just try and parse the JSON on stdout. If the command doesn't
produce JSON fail, then the error handler still exists. Bugs in npm or
packaging like https://bugzilla.redhat.com/show_bug.cgi?id=986422 can
cause package lists to come back empty even if the error's harmless.